fix: [UIE-9816] - Empty state does not display correctly when category filter is selected first#13360
Merged
pmakode-akamai merged 2 commits intolinode:developfrom Feb 5, 2026
Conversation
Collaborator
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
tvijay-akamai
approved these changes
Feb 4, 2026
jdamore-linode
approved these changes
Feb 4, 2026
Contributor
jdamore-linode
left a comment
There was a problem hiding this comment.
Thanks @pmakode-akamai, confirmed this fixes the issue and didn't observe any other issues 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 📝
Previously, when a category filter was selected first, the UI would show a blank screen instead of the "No results found" empty state.
This edge case happened because
filteredProductsstill contained products from other categories, even though theselectedCategoryitself had zero products. As a result, the empty state logic was never triggered.This PR fixes the issue by including the
selectedCategoryin the initial filtering process (when a category is already selected). This ensuresfilteredProductsaccurately reflects the selected category and correctly displays the empty state when no results are available.NOTE: A changeset may not be necessary for this fix since the main PR has not been released yet.
Changes 🔄
Scope 🚢
Upon production release, changes in this PR will be visible to:
Target release date 🗓️
N/A
Preview 📷
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅